Skye Wanderman-Milne has posted comments on this change. Change subject: Reduce dependencies on inline header functions ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/runtime/raw-value.inline.h File be/src/runtime/raw-value.inline.h: Line 32: inline bool RawValue::Eq(const void* v1, const void* v2, const ColumnType& type) { > You're right now that TupleRowComparator is codegened. I'll move it to the I just noticed that the exchange node uses a tuple row comparator and doesn't codegen it. This would be easy enough to remedy, the only wrinkle being it would probably have to obey the same optimization as the parquet scanner with codegening exprs. But maybe hold off on moving this until we fix that? -- To view, visit http://gerrit.cloudera.org:8080/2485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7a2f388cd14a4427c43af2724340a2ffe8fae3d Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
