Jim Apple has posted comments on this change. Change subject: IMPALA-1903: Add support for partitioning by TIMESTAMP ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/1621/3/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: Line 358: CheckParse > Why not just Parse? Done http://gerrit.cloudera.org:8080/#/c/1621/3/fe/src/main/java/com/cloudera/impala/analysis/TimestampLiteral.java File fe/src/main/java/com/cloudera/impala/analysis/TimestampLiteral.java: Line 84: public int compareTo(LiteralExpr o) { > Not really. The default implementation of compareTo in LiteralExpr is well Removed equals() and compareTo(); added a comment. http://gerrit.cloudera.org:8080/#/c/1621/3/fe/src/main/java/com/cloudera/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/com/cloudera/impala/planner/HdfsPartitionPruner.java: Line 182: slot.getType().isTimestamp() || bindingExpr.getType().isTimestamp() > But why do you care about the type of the binding expr? If the binding expr is a timestamp literal and the slot is not, then we still need to evaluate the binding expression in the backend, right? http://gerrit.cloudera.org:8080/#/c/1621/3/testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test File testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test: Line 60: timestamp_col=__HIVE_DEFAULT_PARTITION__ > My main point is that I don't believe we should convert 'invalid timestamp' This is covered in an earlier comment. We decided that it is consistent with the handling of other invalid -> NULL conversions for partition values. http://gerrit.cloudera.org:8080/#/c/1621/3/tests/metadata/test_recover_partitions.py File tests/metadata/test_recover_partitions.py: Line 196: 1987-05-29 15:45:44.6 > There are two paths mentioned in L188-189. The one used here doesn't match No, I was missing something - fixed. -- To view, visit http://gerrit.cloudera.org:8080/1621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad7dcdc1b199cce9483dc414072bbe24efd625c Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
