Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1903: Add support for partitioning by TIMESTAMP ......................................................................
Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/1621/7/testdata/workloads/functional-query/queries/QueryTest/timestamp-partitions.test File testdata/workloads/functional-query/queries/QueryTest/timestamp-partitions.test: Line 295: select count(*) from t4 where t in (p); This doesn't go trigger the partition pruning path, so I don't think it's adding much in terms of test coverage. Same for L314, L333. The rest look good. -- To view, visit http://gerrit.cloudera.org:8080/1621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad7dcdc1b199cce9483dc414072bbe24efd625c Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
