Huaisi Xu has posted comments on this change. Change subject: CDH-38160: Prevent destructing uninitialized avro schema pointers ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2582/2/testdata/avro_schema_resolution/create_table.sql File testdata/avro_schema_resolution/create_table.sql: Line 118: TBLPROPERTIES ('avro.schema.literal'='{"type": "record", "name": "dup1", "fields": [{"name": "a", "type": "int"}]} {"type": "record", "name": "dup1", "fields": [{"name": "a", "type": "int"}]}') > long line looks like in .sql file we do not enforce line width. http://gerrit.cloudera.org:8080/#/c/2582/2/testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test: Line 32: # no code gen > iirc, Impala runs test with both codegen enabled and disabled. I don't thin query option with run-test.py query-test/... is disable_codegen=false. and query option does not necessarily mean code gen is in effective. I followed the code path locally though.. -- To view, visit http://gerrit.cloudera.org:8080/2582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02ae0ba586887e4bb713b993edd208f9421dd1a8 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-HasComments: Yes
