Juan Yu has posted comments on this change. Change subject: CDH-38160: Prevent destructing uninitialized avro schema pointers ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2582/2/testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test: Line 32: # no code gen > the job at most only uses disable_codegen query option. but this does not f I am not sure codegen is disabled with "limit 10" is intended or not. and this behavior might change in the future. Since the main purpose of this test is to verify Impala doesn't crash when codegen is enabled, I think it's ok. another way is you can set "__query_options['disable_codegen']" in pytest. -- To view, visit http://gerrit.cloudera.org:8080/2582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02ae0ba586887e4bb713b993edd208f9421dd1a8 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-HasComments: Yes
