Tim Armstrong has posted comments on this change.

Change subject: Add binutils
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2575/1//COMMIT_MSG
Commit Message:

Line 10: https://issues.cloudera.org/browse/IMPALA-3028 has a little more 
detail.
Put JIRA in first line?


http://gerrit.cloudera.org:8080/#/c/2575/1/init.sh
File init.sh:

Line 169:   # Add ld from binutils to the path so it'll be used.
Should we use ld.gold instead by default?


http://gerrit.cloudera.org:8080/#/c/2575/1/source/binutils/build.sh
File source/binutils/build.sh:

Line 19: THIS_DIR="$(cd "$(dirname "$0")" && pwd)"
How does this work with the nested quotes?


-- 
To view, visit http://gerrit.cloudera.org:8080/2575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f6f0fea3d33872ee2c119fec824afbd7e09886e
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Casey Ching <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to