Huaisi Xu has posted comments on this change.

Change subject: IMPALA-1702: Check duplicated table ID in tables without 
associated TupleDescriptors
......................................................................


Patch Set 2:

I think we should check source of tbl_desc or just tbl_desc itself from the 
thrift request that gets converted to underered_map instead of those from 
analyzer. but anyway, but if we do check analyzer probably we could move this 
upwards so that it errs more quickly? although this is not important... Could 
you take another look at this patch?

-- 
To view, visit http://gerrit.cloudera.org:8080/2570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2a6324cb9e28ba5be4bb525a639433ba3e8782b
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
Gerrit-HasComments: No

Reply via email to