Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-1702: Check duplicated table ID in tables without associated TupleDescriptors ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2570/1/fe/src/main/java/com/cloudera/impala/service/Frontend.java File fe/src/main/java/com/cloudera/impala/service/Frontend.java: Line 1126: for (Table table: referencedTables) { Instead of duplicating the logic above, how about you create a List<Table> containing the tables from all the tuple descs and all the referenced tables, and then loop over all of them here. -- To view, visit http://gerrit.cloudera.org:8080/2570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2a6324cb9e28ba5be4bb525a639433ba3e8782b Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
