Matthew Jacobs has posted comments on this change. Change subject: Improve AtomicInt abstraction and implementation ......................................................................
Patch Set 1: (1 comment) was just taking a look, happy to make a thorough review later if you'd like as well http://gerrit.cloudera.org:8080/#/c/2573/1/be/src/common/atomic.h File be/src/common/atomic.h: Line 49: a specified memory-ordering semantic nit: ...has the specified memory-ordering semantics. -- To view, visit http://gerrit.cloudera.org:8080/2573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2dc1b258ad7ef7ddc3db4e78de3065012cfa923 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
