Dan Hecht has posted comments on this change. Change subject: Improve AtomicInt abstraction and implementation ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2573/1/be/src/runtime/disk-io-mgr-internal.h File be/src/runtime/disk-io-mgr-internal.h: Line 327: __sync_synchronize Will change this to MemoryBarrier() http://gerrit.cloudera.org:8080/#/c/2573/1/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: Line 164: Set Will comment it's atomic -- To view, visit http://gerrit.cloudera.org:8080/2573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2dc1b258ad7ef7ddc3db4e78de3065012cfa923 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
