Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC_FILE ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/2580/1/fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java File fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java: Line 172: * regardless of whether a complex-typed column is actually referenced update comment Line 188: boolean referencesComplexColumns = false; singular (as in: references any complex column); also, "column" is widely abbreviated as "col" Line 190: if (slotDesc.getType().isComplexType()) { why not check for materialization? Line 192: sampleComplexTypedCol = slotDesc.getColumn(); this also changes the logic for non-rc file formats. change it back to firstComplexTypedCol and remove this line Line 200: // Queries on RC_FILE type are allowed as long as they do not refer to complex "complex-typed" -- To view, visit http://gerrit.cloudera.org:8080/2580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a89b211bdc01f7e07497e293fafd75ccf0500fe Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
