Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3194: Allow queries materializing scalar type columns in 
RC_FILE
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2580/2/fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java
File fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java:

Line 189:     boolean referencesAnyComplexTypedCol = false;
> any is superfluous
Done


http://gerrit.cloudera.org:8080/#/c/2580/2/testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test:

Line 43: select id from functional_rc_snap.complextypes_fileformat
> please add the old test case back (which you have to change to reference a 
Not sure which one you are referring to here. There is one test above "select 1 
from functional_rc_snap.complextypes_fileformat t, t.a" which refers a complex 
type and the error is thrown. Other than that didn't change anything in this 
test file.


-- 
To view, visit http://gerrit.cloudera.org:8080/2580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a89b211bdc01f7e07497e293fafd75ccf0500fe
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to