Henry Robinson has posted comments on this change. Change subject: Runtime filters tests ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2297/5/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test: Line 18: row_regex: .*RowsRead: 2.43K .* > let's switch uniformly to Files-/RowsRejected for the non-filtering case (a For this test specifically there are no filters even added to the plan (because RUNTIME_FILTER_MODE=OFF), so the Files / RowsRejected is not even emitted into the profile. Elsewhere I agree we should be consistent. Line 29: row_regex: .*Rows rejected: 2.43K .* > should this be RowsRejected in order to form valid json paths? (can be fixe Possibly (I'm not certain what the JSON requirements are) - but the profile is a long way from being valid JSON in text form right now so I agree we should address those issues in a later patch. -- To view, visit http://gerrit.cloudera.org:8080/2297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d617c6d23ffa394a6eb7ead56f1cfb701e0d90 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-HasComments: Yes
