Marcel Kornacker has posted comments on this change. Change subject: Runtime filters tests ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2297/3/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test: Line 28: row_regex: .*RowsRead: 206 .* > Yes, the number of files / scan ranges / row groups / rows processed and fi as pointed out elsewhere, 'files rejected' of 0 also points out that no filters were applied. http://gerrit.cloudera.org:8080/#/c/2297/3/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test: Line 117: row_regex: .*Rows rejected: 2.43K .* > Rows rejected measures the number of rows rejected by the filter explicitly so then why not use 'rows rejected' in the non-filtering case (such as line 83) as well. -- To view, visit http://gerrit.cloudera.org:8080/2297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d617c6d23ffa394a6eb7ead56f1cfb701e0d90 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-HasComments: Yes
