Matthew Jacobs has posted comments on this change. Change subject: Preview: Re-enable Kudu in build using client stubs when needed ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2585/1/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: Line 34: DECLARE_bool(enable_kudu); I thought that if we were going to have the stubbing at the kudu client level then we wouldn't need to have a gflag or conditional compilation. Or is this just a short term thing until we have the client stubs that do what we want and ideally the proper handling during analysis? Regardless, I also don't see why we'd want both the conditional compilation and a gflag? Can't we just stick with one of them? -- To view, visit http://gerrit.cloudera.org:8080/2585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
