Dan Hecht has posted comments on this change. Change subject: Preview: Re-enable Kudu in build using client stubs when needed ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2585/1/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: Line 294: if (!KuduIsAvailable()) return; is this needed? looks like the code below should work (generally, Close() can be called even if Prepare() fails for other reasons). http://gerrit.cloudera.org:8080/#/c/2585/1/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: Line 196: DCHECK(KuduIsAvailable()); how about making this an if-stmt and removing the one at the callsite? (to hide this stuff inside the kudu-specific code) -- To view, visit http://gerrit.cloudera.org:8080/2585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
