Tim Armstrong has posted comments on this change. Change subject: Support for building LLVM 3.7 and 3.8 on CentOS 5 ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2546/4//COMMIT_MSG Commit Message: Line 14: and also provides an alternative to the gcc runtime C/C++ runtime libraries. > please clarify that we are only doing without it on CentOS 5.8 (as opposed Done. We already use the gcc runtime for cross-compiled IR, and clang-compiled code in general is meant to run on the GCC runtime. The only case I ran into is that __builtin_mul_overflow() calls an emulation function that is available in the Clang runtime but not GCC. We don't even necessarily want that because it is slow. -- To view, visit http://gerrit.cloudera.org:8080/2546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad649363fc64f30e0f17a9d51d7694a6fc00bc12 Gerrit-PatchSet: 4 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
