Dan Hecht has posted comments on this change. Change subject: Support for building LLVM 3.7 and 3.8 on CentOS 5 ......................................................................
Patch Set 5: Code-Review+2 (1 comment) Thanks, the new message makes more sense. http://gerrit.cloudera.org:8080/#/c/2546/5/source/llvm/build-source-tarball.sh File source/llvm/build-source-tarball.sh: Line 44: # Skip this on Centos 5.8 since it depends on perf_event.h. how about: ... As a result, on Centos5.8 we'll only use clang to crosscompile, but not for santizers (e.g. ASAN). -- To view, visit http://gerrit.cloudera.org:8080/2546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad649363fc64f30e0f17a9d51d7694a6fc00bc12 Gerrit-PatchSet: 5 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
