Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage ......................................................................
Patch Set 6: (5 comments) getting close http://gerrit.cloudera.org:8080/#/c/2543/6/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: Line 221: EXPECT_OK(Codec::CreateCompressor(&mem_pool_, true, format, &compressor)); How about you move the CreateCompressor/Close calls into GenerateMultiStreamData and only pass in the format, since GenerateMultiStreamData takes cares of mem mgmt Line 253: memset(&raw_input, 0, sizeof(raw_input)); remove memset Line 259: // pick random-size input data(~1MB), compress it, then concatenate those small How about: Repeatedly pick random-size input data, compress it, .... Also copy random input into single buffer. Or something like that Line 270: int len = RAW_INPUT_SIZE - (rand() % 1024); Maybe make this (rand() % 512), len can be as low as 1 as-is. Also, maybe we don't need to randomize len at all since the input is already randomized? Are you trying to create repetition for the compression algorithm? Line 285: uint8_t input_[2 * 26 * 1024]; nit: put a blank line above here -- To view, visit http://gerrit.cloudera.org:8080/2543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
