Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/2543/7/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: Line 255: // Repeatedly pick random-size input data(~1MB), compress it, then concatenate What does the ~1MB mean? I think this is why I got confused about L270 earlier, isn't the input data closer to 7-8MB? Line 266: EXPECT_OK(Codec::CreateCompressor(&mem_pool_, true, format, &compressor)); Move created compressor above comment -- To view, visit http://gerrit.cloudera.org:8080/2543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
