Casey Ching has posted comments on this change. Change subject: IMPALA-3253: Modify gen_build_version.sh to always output the right version ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2651/1/be/src/common/version.h File be/src/common/version.h: Line 1: // Copyright 2012 Cloudera Inc. Update year Line 15: // This is a generated file, DO NOT EDIT IT. : // To change this file, see impala/bin/gen_build_version.py Remove http://gerrit.cloudera.org:8080/#/c/2651/1/bin/gen_build_version.py File bin/gen_build_version.py: Line 84: return IMPALA_BUILD_VERSION; This looks like its returning a pointer to the stack, how does it work? -- To view, visit http://gerrit.cloudera.org:8080/2651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-HasComments: Yes
