Casey Ching has posted comments on this change.

Change subject: IMPALA-3253: Modify gen_build_version.sh to always output the 
right version
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2651/1/bin/gen_build_version.py
File bin/gen_build_version.py:

Line 84:   return IMPALA_BUILD_VERSION;
> Doesn't the compiler store the strings in the rodata section?
I didn't know it was that smart. Works for me.


-- 
To view, visit http://gerrit.cloudera.org:8080/2651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to