Matthew Jacobs has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2665/1/CMakeLists.txt File CMakeLists.txt: Line 21: ENV{IMPALA_CUSTOM_TOOLCHAIN} do we need to add a new variable or can we check if $ENV{IMPALA_TOOLCHAIN} is set to a valid directory? Eg. if [ -d "$ENV{IMPALA_TOOLCHAIN}" ]; then -- To view, visit http://gerrit.cloudera.org:8080/2665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3bae187cc8a829c693711482c0ec656e41b7bf2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
