Tim Armstrong has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2665/1/CMakeLists.txt File CMakeLists.txt: Line 21: ENV{IMPALA_CUSTOM_TOOLCHAIN} > do we need to add a new variable or can we check if $ENV{IMPALA_TOOLCHAIN} I think we need to distinguish between a toolchain directory with custom bits that you don't want to bootstrap to mess with and a toolchain directory that has the standard bits that bootstrap should update as needed. I think what you described is the old behaviour, where it doesn't touch the toolchain directory if it exists, but this meant that you had to blow away the toolchain directory anytime a dependency is added or updated. -- To view, visit http://gerrit.cloudera.org:8080/2665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3bae187cc8a829c693711482c0ec656e41b7bf2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
