Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/2678
Change subject: IMPALA-2988:Refactor HdfsTableSink::Close() so that it cannot fail ...................................................................... IMPALA-2988:Refactor HdfsTableSink::Close() so that it cannot fail HdfsTableSink::Close() makes calls to functions that can fail with a Status. However, since the function has a void return type, these error statuses are just logged and we cannot take any action according to the type of error. This patch moves the closing of the partition file into the FlushFinal function from Close(), so that in case of an error on closing the file, the error is propagated up and some action can be taken. Also fixed some long lines in this patch. Change-Id: I87afc6def8dc5bac313928a492e251782500e305 --- M be/src/exec/hdfs-table-sink.cc M be/src/exec/hdfs-table-sink.h 2 files changed, 27 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/78/2678/1 -- To view, visit http://gerrit.cloudera.org:8080/2678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87afc6def8dc5bac313928a492e251782500e305 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]>
