Dan Hecht has posted comments on this change. Change subject: IMPALA-2988:Refactor HdfsTableSink::Close() so that it cannot fail ......................................................................
Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/2678/1//COMMIT_MSG Commit Message: Line 7: IMPALA-2988:Refactor HdfsTableSink::Close() so that it cannot fail space after colon http://gerrit.cloudera.org:8080/#/c/2678/1/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 626: SCOPED_TIMER(runtime_profile_->total_time_counter()); should we run this timer during FlushFinal() too? -- To view, visit http://gerrit.cloudera.org:8080/2678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87afc6def8dc5bac313928a492e251782500e305 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
