Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3291. Pause monitor thread should check tcmalloc 
performance
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2707/1/be/src/common/init.cc
File be/src/common/init.cc:

Line 168: alloc_time
Can we differentiate between a process pause and a tcmalloc pause here? If a 
process level pause occurs after L157 it is still counted as a tcmalloc pause. 
It is a corner case, but wondering if thats ok.


-- 
To view, visit http://gerrit.cloudera.org:8080/2707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40516456dda9ea6cfce3f2074ab9a4b25087c4bd
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: Yes

Reply via email to