Dan Hecht has posted comments on this change. Change subject: IMPALA-3291. Pause monitor thread should check tcmalloc performance ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2707/1/be/src/common/init.cc File be/src/common/init.cc: Line 167: MarkThreadIdle > is there any performance consideration with doing this twice a second on a Todd, thanks for answering my question in person (pointing out that this is only marking that this thread is idle and only affects this thread's state). But follow up question: we are assuming no other allocation happens on this thread, right? Are you sure that's the case? Should we do the MarkThreadIdle() before the malloc instead (are the side effects of MarkThreadIdle synchronous)? -- To view, visit http://gerrit.cloudera.org:8080/2707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40516456dda9ea6cfce3f2074ab9a4b25087c4bd Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
