Lars Volker has uploaded a new patch set (#4). Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons ......................................................................
PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons This changes add breakpad crash handling support to catalogd, impalad, and statestored. The destination folder for minidump files can be configured via the 'minidump_path' command line flag. Leaving it empty will disable minidump generation. The daemons will rotate minidump files. The number of files to keep can be configured with the 'max_minidumps' command line flag. TODO: crashing statestored and catalogd after starting them in short succession makes one overwrite the other's minidump file. It looks like the rng is initialized by breakpad during startup and both processes start in the same second. What should we do about this? Make an own minidump folder for each? Just live with it that we will only see one of the dumps? Add a 1 second delay to the startup script? Patch breakpad? Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 --- M CMakeLists.txt M be/CMakeLists.txt M be/src/common/global-flags.cc M be/src/common/init.cc M be/src/util/CMakeLists.txt A be/src/util/minidump.cc A be/src/util/minidump.h M bin/bootstrap_toolchain.py M bin/impala-config.sh A cmake_modules/FindBreakpad.cmake 10 files changed, 253 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/28/2028/4 -- To view, visit http://gerrit.cloudera.org:8080/2028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]>
