Tim Armstrong has posted comments on this change. Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons ......................................................................
Patch Set 6: (4 comments) Some initial comments. Also, is there any way we can test this? It will be a huge headache if we find out the hard way that this got broken. http://gerrit.cloudera.org:8080/#/c/2028/6/be/src/util/minidump.cc File be/src/util/minidump.cc: Line 26: TODO ? Line 51: printf("Wrote minidump to %s\n", descriptor.path()); It would also be helpful to write to stderr so we get it in impalad.ERROR (saves us looking in multiple places). Line 69: string pattern = FLAGS_minidump_path + "/" + Why do we need to match this exact pattern? Presumably anything with a .dmp prefix in the impala-minidump directory is a minidump, right? Line 79: // To prevent us from messing with a file that is currently being written we only Why would a file be being written? This is only checked during startup and the directories are per-daemon. Am I missing something? -- To view, visit http://gerrit.cloudera.org:8080/2028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
