Dan Hecht has posted comments on this change. Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2473/4/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 242: AllocateTupleBuffer would be nice to callout the capacity_ side-effect in the name. Maybe ResizeAndAllocTupleBuffer() or similar? Line 279: fixed_len_limit single quotes Line 281: ComputeEffectiveCapacity This name isn't great but I haven't thought of anything better. Consider just putting this code inside AllocateTupleBuffer() since it doesn't really seem generally useful but is more tied to that routine. -- To view, visit http://gerrit.cloudera.org:8080/2473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd9cd681875821c1c379d97586d3f4850aae622 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
