Dan Hecht has posted comments on this change. Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer ......................................................................
Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/2473/7/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 233: capacity maybe use a different term here given that you mean something different than 'capacity_'. Maybe just delete "in the capacity". Line 240: report "log", to be more specific (errors should also be "reported" by returning the status up the stack). -- To view, visit http://gerrit.cloudera.org:8080/2473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd9cd681875821c1c379d97586d3f4850aae622 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
