Tim Armstrong has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/2113/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 1823: // TODO: inject 'stores_tuples_' so we don't have so much duplicated IR. Don't need this TODO, we have a JIRA: https://issues.cloudera.org/browse/IMPALA-3168 -- To view, visit http://gerrit.cloudera.org:8080/2113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I616f46a861b4909d7a6e66dcf947b3518556768e Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
