Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/2113/5/be/src/exec/partitioned-hash-join-node-ir.cc File be/src/exec/partitioned-hash-join-node-ir.cc: Line 294: void* e = filter_ctx.expr->GetValue(row); leave todos to codegen the expr evaluation and hash value computation as well (or do it) http://gerrit.cloudera.org:8080/#/c/2113/5/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 241: AddCodegenExecOption(insert_codegen_enabled, codegen_status, "Insert"); "insert" is part of build (and it's not even clear unless you know the code really well what "insert" here means), this shouldn't be called out separately. Line 1842: Function* insert_batch_fn = codegen->GetFunction(IRFunction::PHJ_INSERT_BATCH, true); avoid single-line blocks -- To view, visit http://gerrit.cloudera.org:8080/2113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I616f46a861b4909d7a6e66dcf947b3518556768e Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
