Dan Hecht has posted comments on this change. Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage ......................................................................
Patch Set 13: (8 comments) http://gerrit.cloudera.org:8080/#/c/2543/13/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: Line 187: Input is NULL or input_len is 0 the code checks compressed_length, not 'input' nor 'input_len'. should the code be checking input_len instead? or update the comment? Line 232: . let's explicitly say: "We should get expected_stream_end == false but with no error." Line 252: 8MB which constant does this correspond to? can we make the other constants derive from this one? (or is it not exposed?) Line 258: rand can the seed be specified at the command line (to reproduce failures)? Line 273: some space is the "some space" why we do the - RAW_INPUT_SIZE? Or is the choice of RAW_INPUT_SIZE important in some way? please clarify the comment. Line 291: 16 summarize how this is chosen. Line 292: 32 and this Line 294: 2 * 26 and this -- To view, visit http://gerrit.cloudera.org:8080/2543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
