Juan Yu has posted comments on this change. Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/2543/10/be/src/util/decompress.cc File be/src/util/decompress.cc: Line 95: *stream_end = input_length == 0; > Are you sure this is always correct thing to do given the way HdfsTextScann This is for the special case that caller pass in a NULL input, only used in test case. I don't think scanner will send NULL input to decompressor. Maybe I should tweak the test case to not always check stream_end. -- To view, visit http://gerrit.cloudera.org:8080/2543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
