Dan Hecht has posted comments on this change. Change subject: IMPALA-3115: Hoist some variables out of loops in cross-compiled code. ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/2661/4/be/src/exec/partitioned-aggregation-node-ir.cc File be/src/exec/partitioned-aggregation-node-ir.cc: Line 27: __restrict__ if __restrict__ isn't helping the compiler do the reduction of multiplication and hoisting e.g. singleton_output_tuple_, are we getting anything from it? Do we build with -fno-strict-aliasing, and if so is that impacting? Line 30: int i = 0; i < batch->num_rows(); ++i now we have two loop iterators (i and row_batch_iterator). If we want to go this route of having a RowBatch::Iterator, would it work to define an End() method so that it can be the sole iterator? -- To view, visit http://gerrit.cloudera.org:8080/2661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7152b1fb094b3c3574d203e3774f4297f2225dc Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
