Dan Hecht has posted comments on this change. Change subject: IMPALA-3115: Hoist some variables out of loops in cross-compiled code. ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2661/5/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 172: ++row_idx_; > At the end of PartitionedHashJoinNode::ProcessProbeBatch() to update probe_ that might be fine, but then let's not put it in this class since we wouldn't want it to be used normally (like on every iteration). we could just do the calculation in end: But, really we should just replace probe_batch_pos_ with the iterator. I'm not sure how easy that is, though, because of the weird -1 case. But maybe worth looking at for a few minutes. Also, it seems possible to combine probe_batch_pos_ and current_probe_row_, but that might be a can of worms. -- To view, visit http://gerrit.cloudera.org:8080/2661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7152b1fb094b3c3574d203e3774f4297f2225dc Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
