Dan Hecht has posted comments on this change. Change subject: IMPALA-3317: fix crash in sorter when spilling zero-length strings ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/2780/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 477: } else { how about: DCHECK_EQ(var_len_blocks_.back(), cur_var_len_block) to support the index calculation. Line 564: cur_sorted_var_len_block->Allocate<uint8_t>(total_var_len); same dcheck Line 732: // offset in the lower 32 bits. Add: see CopyVarLenDataConvertOffset() Line 827: block_size_ is block_size_ member used anywhere else besides this DCHECK now? Assuming now, consider removing that field and rewriting this dcheck using sorter_->block_mgr_->max_block_size() to discourage reintroduction of this kind of bug. http://gerrit.cloudera.org:8080/#/c/2780/1/tests/query_test/test_queries.py File tests/query_test/test_queries.py: Line 86 why is this deleted? -- To view, visit http://gerrit.cloudera.org:8080/2780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f64593e94d367d6b6efb61a8b86e35516f18839 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
