Dan Hecht has posted comments on this change. Change subject: IMPALA-3317: fix crash in sorter when spilling zero-length strings ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2780/2/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 829: block_size_ still think it'd be good to get rid of block_size_ if it's only used in this dcheck (see previous comment). but okay to ignore if you disagree (or defer to later). -- To view, visit http://gerrit.cloudera.org:8080/2780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f64593e94d367d6b6efb61a8b86e35516f18839 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
