Alex Behm has posted comments on this change. Change subject: IMPALA-3270 & IMPALA-3237: Improve handling of unsupported data types ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2742/3/fe/src/main/java/com/cloudera/impala/catalog/ScalarType.java File fe/src/main/java/com/cloudera/impala/catalog/ScalarType.java: Line 267: if (matchesType(t)) return true; > That's what I did initially, but equals does not work for decimal types. You are right, thanks for clarifying. http://gerrit.cloudera.org:8080/#/c/2742/3/fe/src/test/java/com/cloudera/impala/analysis/AnalyzerTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzerTest.java: Line 556: public void TestUnsupportedTypes() { > So the type centric way would mean all tests that deal with unsupported typ Yea exactly. -- To view, visit http://gerrit.cloudera.org:8080/2742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0acb57d1749978143a3559ae676b882d4b018d58 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
