Alex Behm has posted comments on this change. Change subject: IMPALA-3270 & IMPALA-3237: Improve handling of unsupported data types ......................................................................
Patch Set 5: (2 comments) Almost done. http://gerrit.cloudera.org:8080/#/c/2742/5/fe/src/main/java/com/cloudera/impala/catalog/ScalarType.java File fe/src/main/java/com/cloudera/impala/catalog/ScalarType.java: Line 266: for (ScalarType t: getSupportedTypes()) { Now you can check unsupportedTypes and use equals() http://gerrit.cloudera.org:8080/#/c/2742/5/fe/src/test/java/com/cloudera/impala/analysis/AnalyzerTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzerTest.java: Line 571: AnalysisError("select * from functional.unsupported_types", duplicate with first test in this function -- To view, visit http://gerrit.cloudera.org:8080/2742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0acb57d1749978143a3559ae676b882d4b018d58 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
