Michael Ho has posted comments on this change. Change subject: IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0 ......................................................................
Patch Set 12: (2 comments) Some minor comments. Will take one last pass in the morning. http://gerrit.cloudera.org:8080/#/c/2486/12/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: Line 71: // Bypass Impala-specific logic in AddFunctionToJit(). I am not sure why it needs to by-pass the big if-stmt in AddFunctionToJir(). Why cannot we call codegen->AddFunctionToJit() here ? http://gerrit.cloudera.org:8080/#/c/2486/12/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 701: nit: indentation -- To view, visit http://gerrit.cloudera.org:8080/2486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d7afd05ad3b472a0bfe035bfc3daada5597b2d Gerrit-PatchSet: 12 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
