Michael Ho has posted comments on this change. Change subject: IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0 ......................................................................
Patch Set 12: Code-Review+1 (2 comments) Some minor styling comments. Can you please address the question about the test ? http://gerrit.cloudera.org:8080/#/c/2486/12/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: Line 718: nit: indentation http://gerrit.cloudera.org:8080/#/c/2486/12/be/src/exec/old-hash-table.cc File be/src/exec/old-hash-table.cc: Line 437: nit: indentation -- To view, visit http://gerrit.cloudera.org:8080/2486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d7afd05ad3b472a0bfe035bfc3daada5597b2d Gerrit-PatchSet: 12 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
