Casey Ching has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/2028/9/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: Line 50: def teardown_class(cls): Doesn't this need a "@classmethod"? Line 82: """Check that when a daemon crashes it writes a minidump file.""" Checking that a core dump is created and that all the processes are dead would be nice. If the core dumps are checked, maybe delete them too so they wont accumulate. -- To view, visit http://gerrit.cloudera.org:8080/2028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
