Tim Armstrong has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons ......................................................................
Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/2028/9/be/src/util/minidump.cc File be/src/util/minidump.cc: Line 122: remove > filesystem-util.h has RemovePaths() which looks like it's built for directo I think this is ok. Line 149: bf::create_directories(FLAGS_minidump_path, err); > If the directory already exists, CreateDirectory() removes it before re-cre Hmm, ok, good to know we're not exposed to that bug. I think this is ok, trying to merge the functions sounds more trouble than it's worth. Line 158: bf::permissions(FLAGS_minidump_path, bf::owner_all, err); > I tried that, although I was not really happy with the interface. boost::fi I didn't realise that breakpad already did that: I think we're ok so long as the files aren't readable/writable. http://gerrit.cloudera.org:8080/#/c/2028/9/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: Line 82: """Check that when a daemon crashes it writes a minidump file.""" > I did a little searching and couldn't come up with anything better. Maybe a I"m not sure that I entirely followed? Are core dumps meant to be created, or not created? I feel like we're ok so long as the impalads are dead and the minidumps are there. -- To view, visit http://gerrit.cloudera.org:8080/2028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
