Dan Hecht has posted comments on this change. Change subject: IMPALA-1850: Allow fs.defaultFS to be set to a non-HDFS filesystem ......................................................................
Patch Set 20: (4 comments) http://gerrit.cloudera.org:8080/#/c/1121/20/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: Line 53: #include "util/hdfs-util.h" why is this needed? http://gerrit.cloudera.org:8080/#/c/1121/20/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: Line 125: ///Returns the configured defaultFs set in core-site.xml missing space Line 169: configured_defaultFs_ configured_default_fs_ (or just default_fs_ - either better matches default_fs()) http://gerrit.cloudera.org:8080/#/c/1121/20/be/src/util/hdfs-util.cc File be/src/util/hdfs-util.cc: Line 75: return strncmp(path, "s3a://", 6) == 0; shouldn't we do the same default_fs check here? how are both of these cases tested? -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 20 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
