anujphadke has posted comments on this change. Change subject: IMPALA-1850: Allow fs.defaultFS to be set to a non-HDFS filesystem ......................................................................
Patch Set 20: (4 comments) http://gerrit.cloudera.org:8080/#/c/1121/20/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: Line 53: #include "util/hdfs-util.h" > why is this needed? Forgot to remove this.It was added as part of an earlier review. http://gerrit.cloudera.org:8080/#/c/1121/20/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: Line 125: ///Returns the configured defaultFs set in core-site.xml > missing space Done Line 169: configured_defaultFs_ > configured_default_fs_ (or just default_fs_ - either better matches default changed to defaut_fs_ http://gerrit.cloudera.org:8080/#/c/1121/20/be/src/util/hdfs-util.cc File be/src/util/hdfs-util.cc: Line 75: return strncmp(path, "s3a://", 6) == 0; > Yes, I will make the change here too. Changed the IsS3APath() and verified it locally Where 1 and 0 are the boolean values returned for that path and default_fs_ I0420 13:31:45.515058 9138 exec-env.cc:424] Configured defaultFS: hdfs://localhost:20500 I0420 13:31:45.515067 9138 exec-env.cc:425] hdfs://test : 0 I0420 13:31:45.515072 9138 exec-env.cc:426] test : 0 I0420 13:31:45.515074 9138 exec-env.cc:427] testFile : 0 I0420 13:31:45.515075 9138 exec-env.cc:428] s3a://test : 1 I0420 13:31:45.515076 9138 exec-env.cc:430] Configured defaultFS: s3a:// I0420 13:31:45.515077 9138 exec-env.cc:431] hdfs://test : 0 I0420 13:31:45.515079 9138 exec-env.cc:432] test : 1 I0420 13:31:45.515080 9138 exec-env.cc:433] testFile : 1 -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 20 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
