Henry Robinson has posted comments on this change.

Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
......................................................................


Patch Set 8:

Two changes: the DCHECK() for NALAJ had a negated condition (missed checks 
because I ran in release mode) and the query for subplans changed plan when all 
stats were present, which they weren't on my local machine. The new query is 
much simpler and robust to stats changes thanks to STRAIGHT_JOIN.

-- 
To view, visit http://gerrit.cloudera.org:8080/2783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59a2d9ee03ccea6b674392584e4c7f272233571e
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to