Dan Hecht has posted comments on this change. Change subject: IMPALA-3077: Enable runtime filters when PHJ spills ......................................................................
Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2783/6//COMMIT_MSG Commit Message: Line 63: Change +3% This is the end-to-end increase, right? Do you know what the increase on just the build side CPU time was - comparing filter enabled vs. filter disabled? If not, okay, but I think that's what we should measure particularly for this change since end-to-end time will be specific to the query used to benchmark. In any case, IMPALA-3360 will be worthwhile but we don't have to do it right now. -- To view, visit http://gerrit.cloudera.org:8080/2783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a2d9ee03ccea6b674392584e4c7f272233571e Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
